You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Relation::from_antijoin always returns an empty Relation, regardless of its inputs. That's because the antijoin helper, which takes a JoinInput as its first parameter, operates only on recent tuples.
This is correct for variables, but Relations, which don't change during iteration, only have stable tuples. See #36 (comment) for the reason this must be the case.
To fix this, we should refactor the antijoin helper to work directly on Relations, and pass the proper input from Variable::from_antijoin and Relation::from_antijoin. A regression test is needed as well.
The text was updated successfully, but these errors were encountered:
Now the `antijoin` helper accepts a `Relation`, which does exactly what
we want in `Relation::from_antijoin`, while in `Variable::from_antijoin`
we now explicitly pass just the `recent` `Relation`.
Signed-off-by: Michal Terepeta <[email protected]>
Relation::from_antijoin
always returns an emptyRelation
, regardless of its inputs. That's because theantijoin
helper, which takes aJoinInput
as its first parameter, operates only onrecent
tuples.datafrog/src/join.rs
Lines 65 to 73 in 5bda2f0
This is correct for variables, but
Relation
s, which don't change during iteration, only havestable
tuples. See #36 (comment) for the reason this must be the case.To fix this, we should refactor the
antijoin
helper to work directly onRelation
s, and pass the proper input fromVariable::from_antijoin
andRelation::from_antijoin
. A regression test is needed as well.The text was updated successfully, but these errors were encountered: