Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve graph generator: statement printing, colours, cluster labels #36

Closed
jberthold opened this issue Jan 30, 2025 · 0 comments · Fixed by #43
Closed

Improve graph generator: statement printing, colours, cluster labels #36

jberthold opened this issue Jan 30, 2025 · 0 comments · Fixed by #43

Comments

@jberthold
Copy link
Member

The experimental --dot functionality does not print the statements in a block yet, only the terminator.

  • add printing for statements (render using \l in the node label)
  • extend terminator printing to also show arguments when relevant (e.g., Drop)

Some other improvements should be added while at it

  • add node [shape = box] to the graph properties
  • use background colours for both user functions and internal functions
  • line-break cluster labels not at :: but at whitespace and fixed length (of 25?) (less vertical than breaking on ::)
This was referenced Jan 30, 2025
Merged
Merged
jberthold added a commit that referenced this issue Feb 6, 2025
@jberthold
Some tweaks to graph rendering, remove smir_pretty instances (#43)
2b4d8a9 
* Adds more colours to the graph clusters
* prints statements in basic blocks
* reformats cluster (function) names for fewer line breaks

Closes #36 

Also removes an outdated test module and all mentions of `smir_pretty`
(renaming the crate to stable_mir_pretty)

Closes #40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Some tweaks to graph rendering, remove smir_pretty instances runtimeverification/stable-mir-json
1 participant
@jberthold