Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Keep Hash#symbolize_keys and Hash#stringify_keys ? #245

Closed
trans opened this issue Oct 2, 2015 · 4 comments
Closed

Keep Hash#symbolize_keys and Hash#stringify_keys ? #245

trans opened this issue Oct 2, 2015 · 4 comments

Comments

@trans
Copy link
Member

trans commented Oct 2, 2015

Consider deprecating Hash#symbolize_keys and Hash#stringify_keys. They seem a bit to magical and #rekey is probably the better approach in any case.

Even if we do deprecate them, we can still keep them as non-core requires.

@tilo
Copy link
Contributor

tilo commented Jan 21, 2016

I think that's not a good idea -- using this outside of Rails is very useful!

Instead they should be fixed!
#253

@trans
Copy link
Member Author

trans commented Oct 1, 2016

Okay.

@trans trans closed this as completed Oct 1, 2016
@ioquatix
Copy link
Contributor

Personally I think you could make them non-core. They are useful.. but they also indicate some poor API usage..

@ioquatix
Copy link
Contributor

(E.g. JSON and YAML I believe have ways to load strings as symbols, which would be a lot more efficient.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants