-
-
Notifications
You must be signed in to change notification settings - Fork 70
Add warning notice to Dashboard page and Partner Request page when pa… #410
base: main
Are you sure you want to change the base?
Conversation
f7dce4f
to
3e8cc77
Compare
@@ -1,13 +1,13 @@ | |||
class PartnerRequestsController < ApplicationController | |||
before_action :authenticate_user! | |||
before_action :verify_status_in_diaper_base |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does this cause a redirect when accessing the index page? If so, I think we don't want to do that. Because the partners should still have access to historical requests.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In addition, would you be able to add text in the area where the request buttons would be? Such that we can explain to the users why the buttons are not visible?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This action permit the Partner access the historical requests normally, and this doesn't redirect to index page.
About the text, this action shows a message that the partner has been deactivated but we can add text in the request button area
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
hey there @EmersonManabuAraki -- I was wondering about:
This action permit the Partner access the historical requests normally, and this doesn't redirect to index page.
The definition of verify_status_in_diaper_base
is:
def verify_status_in_diaper_base
if current_partner.status_in_diaper_base == "deactivated"
flash[:alert] = 'Your account has been disabled, contact the organization via their email to reactivate'
redirect_to partner_requests_path
end
end
Wouldn't this prevent access to the #index action if current_partner.status_in_diaper_base == "deactivated"
is true?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In this case no, because the redirection was removed
3e8cc77
to
1a36583
Compare
…rtner is deactivated
1a36583
to
7c9e88f
Compare
…rtner is deactivated
Resolves #390
Description
Add warning notice to Dashboard page and Partner Request page when partner is deactivated.
Type of change
How Has This Been Tested?