We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
The String#match is doing funny things
String#match
irb(main):023:0> "vg?1".match "vg?1" => nil irb(main):024:0> "g?1".match "g?1" => #<MatchData "1">
here
ferrum/lib/ferrum/network/intercepted_request.rb
Line 33 in 7ae00e7
def match?(regexp) not not regexp === url end
because it was too surprising that when I added an exact url string it didn't match, such as "https://telegram.org/img/tgme/pattern.svg?1".
"https://telegram.org/img/tgme/pattern.svg?1"
Have no time to come up with a PR, just patched in a fork.
The text was updated successfully, but these errors were encountered:
No branches or pull requests
The
String#match
is doing funny thingshere
ferrum/lib/ferrum/network/intercepted_request.rb
Line 33 in 7ae00e7
and since you send regex on url and not vice versa, I believe it isn't intended.
So I propose to make it like this instead:
because it was too surprising that when I added an exact url string it didn't match, such as
"https://telegram.org/img/tgme/pattern.svg?1"
.Have no time to come up with a PR, just patched in a fork.
The text was updated successfully, but these errors were encountered: