Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve Rails/RakeEnvironment cop #1156

Closed
ydakuka opened this issue Oct 14, 2023 · 4 comments
Closed

Improve Rails/RakeEnvironment cop #1156

ydakuka opened this issue Oct 14, 2023 · 4 comments

Comments

@ydakuka
Copy link

ydakuka commented Oct 14, 2023

The cop accepts two valid styles. I think one should be the preferred choice.

desc 'delete non-unique banners'
task 'delete_non_unique_banners' => :environment do
  # ...
end

or

desc 'delete non-unique banners'
task delete_non_unique_banners: :environment do
  # ...
end
@koic
Copy link
Member

koic commented Oct 14, 2023

This should be a role of RuboCop Rake, not a role of RuboCop Rails.
https://github.com/rubocop/rubocop-rake

@koic koic closed this as not planned Won't fix, can't repro, duplicate, stale Oct 14, 2023
@ydakuka
Copy link
Author

ydakuka commented Oct 14, 2023

Could you please transfer the issue?

@koic
Copy link
Member

koic commented Oct 14, 2023

The title for maintaining RuboCop Rake seems unclear. Instead of a transfer, could you please open it again on RuboCop Rake with a clear intent written anew?

@ydakuka
Copy link
Author

ydakuka commented Oct 14, 2023

OK, thanks for the explanations.

rubocop/rubocop-rake#51

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants