Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

JUnit bundled into libary #39

Open
rmeissner opened this issue Jan 25, 2018 · 2 comments
Open

JUnit bundled into libary #39

rmeissner opened this issue Jan 25, 2018 · 2 comments

Comments

@rmeissner
Copy link

rmeissner commented Jan 25, 2018 •
edited
Loading

When we were inspecting our runtime dependencies we realized that spongycastle bundles JUnit. Is this really necessary?

debugCompileClasspath - Resolved configuration for compilation for variant: debug
.
.
.
+--- com.madgag.spongycastle:prov:1.58.0.0
|    +--- com.madgag.spongycastle:core:1.58.0.0
|    \--- junit:junit:4.12
|         \--- org.hamcrest:hamcrest-core:1.3
@rmeissner
Copy link
Author

This can be fixed my merging #38

@jbuhacoff
Copy link

You can build your own BC/SC jars from the current version (1.62), see my comment on issue #34.

@SDILogin SDILogin mentioned this issue Nov 9, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@rmeissner @jbuhacoff