New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support demurrage and commission fees of underlying token #34

Open

hellwolf opened this issue Dec 17, 2019 · 0 comments

Labels

Milestone

Collaborator

hellwolf commented Dec 17, 2019

The underlying token may have:

demmurage fee, which takes periodically from the owner of the tokens
commission fee, which takes for each ERC20.transfer

The currently rTOKEN contract does not support neither of these.

ACs:

Correctly account the loss of underlying tokens in these cases
A test case to demonstrate that.

hellwolf added the enhancement label

hellwolf added this to the 1.1 milestone

hellwolf removed this from the 1.1 milestone

pi0neerpat added the sc label

pi0neerpat added this to the 1.1 milestone

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment