Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change in xdo_search_t structure #29

Open
amasmiller opened this issue Oct 19, 2021 · 0 comments
Open

Change in xdo_search_t structure #29

amasmiller opened this issue Oct 19, 2021 · 0 comments

Comments

@amasmiller
Copy link

amasmiller commented Oct 19, 2021

When using python-libxdo v0.1.2a1 against libxdo version 3.20210903.1, I found the xdo_search_windows function was not working as expected.

I traced down the issue to a changed xdo_search_t structure made in this recent change to libxdo.

After making this modification:

+++ /usr/local/lib/python3.5/dist-packages/xdo/xdo.py   2021-10-19 11:39:04.453431051 
-0500
@@ -229,20 +229,23 @@

     # const char *winclass; pattern to test against a window class
     ('winclass', c_char_p),

     # const char *winclassname; pattern to test against a window class
     ('winclassname', c_char_p),

     # const char *winname; pattern to test against a window name
     ('winname', c_char_p),

+    # const char *winrole; pattern to test against a window role
+    ('winrole', c_char_p),
+
     # int pid; window pid (From window atom _NET_WM_PID)
     ('pid', c_int),

     # long max_depth; depth of search. 1 means only toplevel windows
     ('max_depth', c_long),

     # int only_visible; boolean; set true to search only visible windows
     ('only_visible', c_int),

     # int screen; what screen to search, if any. If none given,

After the modification, the search worked as expected.

amasmiller pushed a commit to amasmiller/python-libxdo that referenced this issue Oct 21, 2021
user202729 added a commit to user202729/python-libxdo-ng that referenced this issue Oct 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant