Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Opening msg definition files failes on Windows #14

Open
eibach opened this issue Apr 30, 2020 · 2 comments
Open

Opening msg definition files failes on Windows #14

eibach opened this issue Apr 30, 2020 · 2 comments
Labels

Comments

@eibach
Copy link

eibach commented Apr 30, 2020

When I try to start the sample programs(Windows, VS2017) I get errors concerning the format of the message definition files in the db folder.

@eibach
Copy link
Author

eibach commented Apr 30, 2020

Ok, got it. It's all about using "rb" in fopen() which leads to windows line endings not transformed, which results in strtok() doing the wrong thing. Should I supply a Pull request?

@gavanderhoorn
Copy link
Member

If you've found an issue it would be great if you could contribute a PR which fixes it.

Do take into account this code is supposed to be platform agnostic (or at the very least work on Linux and Windows), so it may be necessary to "intelligently" add or remove the b there (read: conditionally compile probably).

@gavanderhoorn gavanderhoorn changed the title Samples not working Opening msg definition files failes on Windows Nov 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants