Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make this package into a dependency of clisops #2

Open
agstephens opened this issue Jun 30, 2021 · 6 comments
Open

Make this package into a dependency of clisops #2

agstephens opened this issue Jun 30, 2021 · 6 comments
Assignees

Comments

@agstephens
Copy link
Contributor

...so that it is always available, and the tests run, and the roocs.ini file knows how/where to find it...

...which means writing an appropriate setup.py file.

@agstephens agstephens self-assigned this Jun 30, 2021
@Zeitsperre
Copy link
Collaborator

@agstephens

Is this still project still of use? I imagine it depends on @sol1105's PR. I can help with the packaging if need be.

@agstephens
Copy link
Contributor Author

@Zeitsperre, I think that @sol1105 set this repository up as a dependency for the grid definitions used by clisops. @sol1105: could you please advise @Zeitsperre on whether this repo is still used by clisops and whether we should make it a formal dependency of clisops.

@sol1105
Copy link
Collaborator

sol1105 commented Aug 30, 2023

@agstephens @Zeitsperre
It is a clisops dependency that would be introduced with the regridding PR roocs/clisops#243 . It could also be optional but it is required eventually for the Copernicus Climate Change Service regridding functionality. It provides a set of pre-defined descriptions of commonly used regular grids (ERA-Interim, MERRA-2, global 1 degree, ...) to serve as target grids for remapping operations.

At the moment it is getting installed directly from the github repository with pip, as specified in the clisops environment.yml.

What steps would be necessary to turn it into a formal clisops dependency?

@Zeitsperre
Copy link
Collaborator

@sol1105

Hi Martin, not too much would be needed to bring this up to speed. I can perform some basic package health checks and changes, then push this package to PyPI. Once it's listed there, we can list it as a true dependency (or optional dependency) of CLISOPS. We could then push it to conda-forge, and then it'll officially be in our dependency pipelines.

@Zeitsperre
Copy link
Collaborator

@agstephens

Would it be possible to extend write (ideally "maintain") access to me ? It'll be easier for me to propose some PRs.

@agstephens
Copy link
Contributor Author

@agstephens

Would it be possible to extend write (ideally "maintain") access to me? It'll be easier for me to propose some PRs.

@Zeitsperre: All done. Thanks for picking this up.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants