Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Package Maintenance #3

Open
mynameismon opened this issue Jul 17, 2021 · 10 comments
Open

Package Maintenance #3

mynameismon opened this issue Jul 17, 2021 · 10 comments

Comments

@mynameismon
Copy link
Contributor

mynameismon commented Jul 17, 2021

As one can infer from the history, this package has not been updated since 2016. In the meantime, some great community forks have popper up, the more prominent of them being:

Would it be possible to merge all those changes to create a new version of the package that will hopefully be more up to date?

@ronjouch
Copy link
Owner

ronjouch commented Jul 17, 2021

Hi @mynameismon , author here. Indeed, I'm no longer maintaining or using whoarder. See my answer to #1 (comment) . As you'll see there, I'm willing to merge things and cut a new release, but I don't want to be the one spelunking for changes to bring back from forks.

→ If you have the time, can you do the work of sorting out what should be brought back from forks, get in touch with fork authors, and ask them to publish PRs here?

Thanks for your interest.

@mynameismon
Copy link
Contributor Author

I wouldn't be able to do everything, can you perhaps take a part of that up? Maybe contacting people for PRs, and then I could take it forward from there.

@ronjouch
Copy link
Owner

I wouldn't be able to do everything, can you perhaps take a part of that up? Maybe contacting people for PRs, and then I could take it forward from there.

@mynameismon contacting fork authors for PRs would be awesome. Thanks 🙂.

@mynameismon
Copy link
Contributor Author

mynameismon commented Jul 17, 2021

(p.s. if possible, can the parser be split from the HTML generator? The parser is fantastically good and I want to use it one of my side projects)

@ronjouch
Copy link
Owner

(p.s. if possible, can the parser be split from the HTML generator? The parser is fantastically good and I want to use it one of my side projects)

If "splitting the parser" means making a new pip package, no. Just copy-paste it in your side project? Or extract it into a new project that you maintain and publish to pip.

@mynameismon
Copy link
Contributor Author

Not a separate project, but a separate repository? This way I would be able to include it as a submodule.

@mynameismon
Copy link
Contributor Author

Hi @ronjouch, any updates regarding this?

Would it also be possible to review my PR (#2)

@ronjouch
Copy link
Owner

Hi @ronjouch, any updates regarding this?

I did reply to you about the parser split. Copy / fork it and be the maintainer of it.

Would it also be possible to review my PR (#2)

Yes, will come to it, haven't forgotten about it.

@mynameismon
Copy link
Contributor Author

mynameismon commented Jul 20, 2021

I did reply to you about the parser split. Copy / fork it and be the maintainer of it.

Apologies. I meant this: #3 (comment)

@ronjouch
Copy link
Owner

I did reply to you about the parser split. Copy / fork it and be the maintainer of it.

Apologies. I meant this: #3 (comment)

@mynameismon ooooooooh. I misread your sentence, I read it as "I, Monish, will get in touch with forks, then once PRs are submitted, you Ronan can take it forward from here (reviewing and merging)". My mistake, sorry. But so, to sum up: I will only do minimal work on this library.

If you push me PRs or succeed at convincing fork authors to submit their patches, I will review them and merge them when they { make sense, are tested }. But I will not take time to haul people and ask for patches.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants