Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Manual Input #1

Open
ronelm2000 opened this issue Apr 9, 2020 · 2 comments
Open

Manual Input #1

ronelm2000 opened this issue Apr 9, 2020 · 2 comments
Assignees
Labels
enhancement New feature or request

Comments

@ronelm2000
Copy link
Owner

ronelm2000 commented Apr 9, 2020

Users should be able to enter translations and new card details manually. This can be done via a new parser which will take in an input file.

The input file shall be in JSON. This allows inputs to be easier to define and do not scale vertically as they can introduce problems when editing manually.

This needs to be well defined before work on it can be started.

@ronelm2000 ronelm2000 changed the title **Manual Input** Manual Input Apr 9, 2020
@armswar88
Copy link

Users should be able to enter translations and new card details manually. This can be done via a new parser which will take in an input file.

The input file shall be in JSON. This allows inputs to be easier to define and do not scale vertically as they can introduce problems when editing manually.

This needs to be well defined before work on it can be started.

For input file specs, may I suggest the following as a first iteration:

  • Must be a pure text file (eg. text)
  • Cannot be rich text like rtf, doc, etc.
  • Must be in an identical format as the HotC format you are already parsing in earlier versions of your product.

By going this way, hoping that you can reuse the same parser that you created for parsing the HotC feed to read in text files. Attached a sample for reference.
sample.txt

Thanks for taking on this project! You're helping people connect in this dark time!

@ronelm2000
Copy link
Owner Author

HOTC-style input should be fine I guess. It shouldn't be too difficult for that parser to accept a file. However, a format independent from HOTC is still the ideal format other purposes:

  • It allows other contributors to create exporters and/or set editor applications around that format without worrying about how to export a format into HOTC. There's several JSON encoders and editors, all of which are very easy to use.
  • HOTC style format may be changed at any time. A new input format would be versioned by me and thus won't be changed unless something happens (like a new mechanic).
  • Encore Decks JSON would also work but that JSON format (the one in their Set API) has fields that potential users don't need, like card set limitations, etc.

I still like the idea for HOTC file parser tho, so I will include that as a separate card.

@ronelm2000 ronelm2000 self-assigned this Apr 16, 2020
@ronelm2000 ronelm2000 added the enhancement New feature or request label Apr 16, 2020
ronelm2000 pushed a commit that referenced this issue Jul 2, 2020
@ronelm2000 ronelm2000 moved this to In progress in wsmtools Nov 17, 2022
@ronelm2000 ronelm2000 moved this from In progress to Deferred in wsmtools Nov 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Status: Deferred
Development

No branches or pull requests

2 participants