Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Maybe in the future we should abandon the shateTemplateFunc function and accept template functions in the constructor. #28

Closed
ge3224 opened this issue Dec 9, 2024 · 1 comment
Closed

Maybe in the future we should abandon the shateTemplateFunc function and accept template functions in the constructor. #28

ge3224 opened this issue Dec 9, 2024 · 1 comment

Comments

@ge3224
Copy link
Contributor

ge3224 commented Dec 9, 2024 •
edited
Loading

I think it's right and we can merge it now, but maybe in the future we should abandon the shateTemplateFunc function and accept template functions in the constructor.

Originally posted by @romsar in #27 (comment)

Knowing that you have this in mind, I can create a separate PR and implement this refactor. This is fairly straight forward to do.
@ge3224 ge3224 mentioned this issue Dec 9, 2024
Open
@romsar
Copy link
Owner

romsar commented Dec 13, 2024

Yup, I think we should delete this function.

@romsar romsar closed this as completed Jan 20, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@romsar @ge3224