Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop cabal flags as a mean to add capabilities to etc #43

Open
locallycompact opened this issue Jun 22, 2018 · 7 comments
Open

Drop cabal flags as a mean to add capabilities to etc #43

locallycompact opened this issue Jun 22, 2018 · 7 comments

Comments

@locallycompact
Copy link
Contributor

Hi, I'm using this as a dependency in a project on hackage but it's failing to build the executable. I guess it's something to do with the flags in stack.yaml not reaching hpack? Is it possible to declare these in hpack directly?

Here's the error: http://hackage.haskell.org/package/baserock-schema-0.0.3.4/reports/3

@roman
Copy link
Owner

roman commented Jun 26, 2018

Indeed, the problem is that the cli cabal flag is not true, you need to specify the cabal flags to whatever is building your project, I don't know if you can specify the cabal flags on the .cabal file itself

@locallycompact
Copy link
Contributor Author

The .cabal file is autogenerated by hpack, I'm not sure how to specify these flags in the .package file.

@roman
Copy link
Owner

roman commented Jun 27, 2018

Who is calling the cabal command? I know you can specify cabal flags via CLI

@locallycompact
Copy link
Contributor Author

I have no idea what calls the cabal command on hackage, it doesn't seem to say in the build log.

@locallycompact
Copy link
Contributor Author

Is it possible to release a version that has these flags on by default? I don't really understand the use case for having these features disabled.

@locallycompact
Copy link
Contributor Author

I've asked on freenode and been told it isn't possible to express a dependency on a package built with a specific flag, so it doesn't seem like hackage will be able to build projects using etc while the feature flags are disabled by default.

@roman
Copy link
Owner

roman commented Jul 4, 2018

Is it possible to release a version that has these flags on by default? I don't understand the use case for having these features disabled.

I'm sorry for the troubles @locallycompact; I did add the cabal flags to reduce the footprint of dependencies.

I'll add tickets to re-implement this feature strategy by having different projects:

  • etc-cli
  • etc-yaml
  • etc-utils

These changes will require some refactoring of the internals of the project. I think those are necessary to move forward with adding new backends (AWS parameter-store comes to mind).

Thanks for using the library, and apologies for choosing Cabal Flags for this functionality :-(

@roman roman changed the title Package builds fine with stack but not on hackage Drop cabal flags as a mean to add capabilities to etc Jul 14, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants