You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Is your feature request related to a problem? Please describe.
The PSF subtraction step currently does not propagate errors at all. It also replaces all pixels with a DQ value > 0 with nans and then flags the nan pixels in the output dataset, however the presence of nans in the reference images causes... interesting results.
Here is the result for an idealized psf subtraction with no dqs/nans present and a roll angle of 45 degrees. The bottom left panel shows the output image, which matches the expected result perfectly:
And here is the result with a stripe of nans in the science image, causing a major offset in the output image:
And this is the result with a stripe of nans in the science image and a stripe of nans in the reference image. You can see the stripe of nans in the reference image causes all sorts of artifacts:
Describe the solution you'd like
We should make sure PSF subtraction step propagates errors (I think there's a way to pass them to pyKLIP) and test that it works correctly.
We should determine what the expected behavior is for nan pixels in the reference images (or require that no nans/dq flags are present) and make sure we're getting the right result.
Additional context
None.
The text was updated successfully, but these errors were encountered:
Is your feature request related to a problem? Please describe.
The PSF subtraction step currently does not propagate errors at all. It also replaces all pixels with a DQ value > 0 with nans and then flags the nan pixels in the output dataset, however the presence of nans in the reference images causes... interesting results.
Here is the result for an idealized psf subtraction with no dqs/nans present and a roll angle of 45 degrees. The bottom left panel shows the output image, which matches the expected result perfectly:
And here is the result with a stripe of nans in the science image, causing a major offset in the output image:
And this is the result with a stripe of nans in the science image and a stripe of nans in the reference image. You can see the stripe of nans in the reference image causes all sorts of artifacts:
Describe the solution you'd like
We should make sure PSF subtraction step propagates errors (I think there's a way to pass them to pyKLIP) and test that it works correctly.
We should determine what the expected behavior is for nan pixels in the reference images (or require that no nans/dq flags are present) and make sure we're getting the right result.
Additional context
None.
The text was updated successfully, but these errors were encountered: