Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: rodgc/ngx-socket-io
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: v4.8.1
Choose a base ref
...
head repository: rodgc/ngx-socket-io
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: master
Choose a head ref
  • 3 commits
  • 6 files changed
  • 2 contributors

Commits on Dec 27, 2024

  1. Export SOCKET_CONFIG_TOKEN (#188)

    This is needed if one needs to extend a basic configuration with
    namespaces, for example.
    barbieri authored Dec 27, 2024
    Copy the full SHA
    64774f4 View commit details
  2. Fix and sync api wrapper (#190)

    * Fix socket.of() method
    
    Socket-io's of() only exists in the server API and it returns a new
    instance.
    
    For client we must create a new `io()` with the URL containing the
    namespace. Let's do this and share instances whenever the namespace is
    reused.
    
    * Fix chaining methods
    
    Since we're wrapping the socket, we must return ourselves and not the
    internal socket.
    
    * Fix volatile usage
    
    It's a getter that toggles a flag, but then we must return the actual
    instance
    
    * Add return types to help users
    
    Since we're not importing socket.io-client typings, these are
    particularly important to avoid `any`
    
    * Add emitWithAck()
    
    * Add offAny() and offAnyOutgoing()
    
    These match onAny() and onAnyOutgoing()
    
    * Add send()
    
    Basically emit('message', ...args)
    
    * Add compress()
    
    * Add attributes
    
    * Fix connect() and disconnect() arguments
    
    According to
    https://github.com/socketio/socket.io/blob/main/packages/socket.io-client/lib/socket.ts
    and https://socket.io/docs/v4/client-api/
    these functions do not receive any arguments.
    barbieri authored Dec 27, 2024
    Copy the full SHA
    0cda11e View commit details
  3. Release v4.8.2

    rodgc committed Dec 27, 2024
    Copy the full SHA
    d5f9d72 View commit details
Loading