Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wget2 regression: Progress info completely bogus, for timed-out-retried instances #327

Open
HinTak opened this issue Jul 8, 2024 · 1 comment

Comments

@HinTak
Copy link

HinTak commented Jul 8, 2024

This might be slightly difficult to reproduce - perhaps from a laptop with WiFi switch off in the middle?

I am watching one such going on. Started with "wget -x -N ...". Anyway, just a single large file of 11MB.

It displays in red, "just got 3MB of 11MB", "4.5MB...", "5.2MB", "6.9MB" so it looks like it was timed out and re-tried 4 times. And below it,

4 files ..... 65% 35MB

(Note it is only a single file of 11MB, just timed out and retried 4 times). Then at 65%, it finishes - instead of 100%.

So the progress bar is essentially meaningless after a timed-out retry.

@rockdaboot
Copy link
Owner

The progress bar indeed need some love. I just pushed a commit that updates the progress report [Files: .... every second.

Especially with HTTP/2, a single bar may display completely nonsense, as it assumes a single download per connection. And with HTTP/2, we often do many downloads in parallel per connection. This needs to be reworked.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants