ConfigSchema type check bug

[jliersch]

Situation

When type checking a double as a number defined in a ConfigSchema, I got an error for invalid type (cf. envire/envire-envire_types#5 (comment)). Investigating the type of the item before the check in has_corresponding_type (see below) it seems like the type of the corresponding config item is undefined at config_item.getOrCreateAtom()->getType().

configmaps/src/ConfigSchema.cpp

Lines 36 to 48 in 07324d9

	bool ConfigSchema::has_corresponding_type(ConfigItem &config_item, const std::string &type)
	{
	if (type == "object")
	return config_item.isMap();
	if (type == "array")
	return config_item.isVector();
	// TODO: for some reason ConfigAtom STRING_TYPE needs to be tested with testType() instead of getType() to detect its type..
	if (type == "string")
	return config_item.getOrCreateAtom()->testType(ConfigAtom::STRING_TYPE);
	return std::find(SCHEMA_ATOM_TYPES.at(type).begin(), SCHEMA_ATOM_TYPES.at(type).end(),
	config_item.getOrCreateAtom()->getType()) != SCHEMA_ATOM_TYPES.at(type).end();
	}

Task

Ensure the type is set prior to calling getType or use testType for atomic types.

[jliersch]

Closed with merge of #23

[jliersch]

The same problem also could occur when using minimum or maximum values in a schema.

[jliersch]

Closed with merge of #24