Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Choices Searches on Control and Alt #752

Open
TobiasLounsbury opened this issue Jan 3, 2025 · 0 comments
Open

Choices Searches on Control and Alt #752

TobiasLounsbury opened this issue Jan 3, 2025 · 0 comments
Labels
enhancement New feature or request

Comments

@TobiasLounsbury
Copy link
Contributor

maryUI version

1.41.5

daisyUI version

4.5.0

Livewire version

3.5.12

What browsers are affected?

Firefox, Chrome, Safari, Microsoft Edge

What happened?

When using Choices the search function is triggered by several non-character keys. Tab, the arrows, and a few are already excluded but there are a few more that I believe need to be added. In the long run, maybe after v2 is out and working smoothly, it might be worth exploring a more comprehensive mechanism for checking that the search string has actually changed since the last time we triggered it, but for now as a simple uncomplicated fix I recommend adding the following non-character keys to the exception list:
'Control', 'Alt', 'Home', 'End', 'PageUp', 'PageDown'

PR incoming.

@TobiasLounsbury TobiasLounsbury added the bug Something isn't working label Jan 3, 2025
@robsontenorio robsontenorio added enhancement New feature or request and removed bug Something isn't working labels Jan 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants