Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create formula to push into homebrew-core #17

Open
ronaldtse opened this issue Jan 8, 2020 · 4 comments
Open

Create formula to push into homebrew-core #17

ronaldtse opened this issue Jan 8, 2020 · 4 comments
Assignees

Comments

@ronaldtse
Copy link
Contributor

As the RNP repo has over 50 stars, we are allowed to merge into homebrew official.

This task is to create a fork of homebrew-core, and make a PR to merge the RNP formula into Homebrew official.

@rrrooommmaaa could you help us with this? Thanks!

@rrrooommmaaa
Copy link
Contributor

Shouldn't we have GHA on main rnp repository?
Otherwise, we won't be able to merge this repo to homebrew-core?

@ronaldtse
Copy link
Contributor Author

@rrrooommmaaa to merge into homebrew-core, we have to fork homebrew-core, create the rnp formula there, and submit a PR.

The star count only applies to the software itself, not the formula.

@rrrooommmaaa
Copy link
Contributor

@ronaldtse I created a PR Homebrew/homebrew-core#49403 and they responded with GitHub repository not notable enough (<30 forks, <30 watchers and <75 stars)
I'll fix other recommendations meanwhile.

@ronaldtse
Copy link
Contributor Author

Interesting, so they've raised the bar for acceptance for "notability". Agree let's fix up the recommendations.

Pinging @rnpgp/developers to "fork" + "watch" + "star" the main https://github.com/rnpgp/rnp repo.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants