-
Notifications
You must be signed in to change notification settings - Fork 164
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Audiobookshelf and using comma to seperate genres (and maybe other list metadata?) #1107
Comments
I feel like this is an enhancement and not a bug. If you feel strongly otherwise though I can change it back. |
that's fine with me o7 |
I was just reading a discussion about this on the ABS repo here... advplyr/audiobookshelf#3127 Don't know how true this is, but it's mentioned that Libation is about the only app that uses commas between genres. The issue people are having is that Audible has a few genres with |
If there's a standard I can easily change. I chose that because it just felt natural. I'm in no way married to the comma. |
I don't know much programming but in the ones I do know i think this would be handled one of 2 ways. Either |
This actually comes directly from audible; I don't touch 'genre'. I looked through my code and the code of the audio library I use and nowhere is genre manipulated. Evidently it wasn't me after all. I was thinking of "Categories." |
Ah. I was assuming that it came from Audible in an array in a json format, and you concatenated them as a list, using Edit: "category_ladders": [
{
"ladder": [
{
"id": "18580606011",
"name": "Science Fiction & Fantasy"
},
{
"id": "18580628011",
"name": "Science Fiction"
},
{
"id": "18580645011",
"name": "Space Opera"
}
],
"root": "Genres"
}
], |
Doing some Googling, I've been reading that the "standard" ways of doing multiple genres is to use either Edit: |
If it's embedded in the file (ie: id3 metadata tags) then it just means that audible populates these in the audio file, encrypts the file, and they're still there when I decrypt. What appears in that json file is not guaranteed to match the file. They come via 2 separate routes. Audible does some wonky things like this. If I recall, there's chapter info embedded in the file itself, but the official audible app actually downloads a separate bit of data via their api (like with that json above) and uses that instead. Michael and I got to discover this when a user had different results when playing the file as a single file (chapter info was embedded) vs splitting files by chapter (Libation used the api to get chapter divisions and info. |
Oh, lovely. :-D Gotta love the "standards" that Audible is using. Maybe we should be using the API to download the categories/genres as well? |
Perhaps. There's no easy answer. Some people feel strongly about having it as correct as possible, some feel strongly about it being as untouched as possible by other software, some think there should be more and more settings to let them personalize endlessly, and some think there should be fewer settings and it should be simple. "You can't please all the people all the time. And last night, all those people were at my show.
|
Yeah, was thinking about that. Question is, which is more "correct" in this case. I'm guessing that the categories through the API might be updated more often than the media files, so those might end up being more "correct"? Was thinking that because they can fix those without having to redo the media file itself. |
Describe the bug
So not strictly a bug but an incompatibility with Audiobookshelf, I've raised an issue on their end as well.
Basically the Genre metadata in the files being downloaded with libation are currently causing Audiobookshelf to list them as one giant genre rather than seperate genres. I'm not sure if this on your side or Audible's side but the simple fix would seem to be to use ; rather than , to seperate genres especially since some audible genre's include apostrophes.
To Reproduce
Steps to reproduce the behavior:
Expected behavior
A clear and concise description of what you expected to happen.
Screenshots
If applicable, add screenshots to help explain your problem.
Platform
Synology Docker
The text was updated successfully, but these errors were encountered: