Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wildcard search improvements #26

Open
davidteal opened this issue Jan 26, 2017 · 0 comments
Open

Wildcard search improvements #26

davidteal opened this issue Jan 26, 2017 · 0 comments

Comments

@davidteal
Copy link

Hi there.

As far as I can see, I don't think wildcard searches work on urls with a query string as the preg_match tries to use the ? as part of the expression. I fixed this by escaping ? characters in the str_replace.

Also, using * as the start of the redirect doesn't work due to using strpos($record['uri'], "*") which returns 0 and therefore doesn't pass the if statement. Should use strpos($record['uri'], "*") !== false

Happy to submit PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant