Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lang-6 is fixed with wrong patch #618

Open
zeyugao opened this issue Sep 25, 2024 · 0 comments
Open

Lang-6 is fixed with wrong patch #618

zeyugao opened this issue Sep 25, 2024 · 0 comments

Comments

@zeyugao
Copy link

zeyugao commented Sep 25, 2024

The original issue: https://issues.apache.org/jira/browse/LANG-857

The original patch: apache/commons-lang@52bcd9b

But after digging it for a while, and checking against with the current version of commons-lang, the original patch is reverted (apache/commons-lang@ab14240#diff-a52232956711fb9042d1101775d44638e95bb979e1c73af2bf48d72d7c41d39cL95) and fixed with another commit: apache/commons-lang@ab14240#diff-5a1a900485fdfb970dd171f94df72a0a5e98da858739304784aa8482c48e40feL183

The correct fix should be placed in the CsvEscaper: apache/commons-lang@ab14240#diff-5a1a900485fdfb970dd171f94df72a0a5e98da858739304784aa8482c48e40feL166-L190

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants