Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fails to handle error if champ more than 4 #19

Closed
rizky opened this issue Apr 24, 2018 · 0 comments
Closed

Fails to handle error if champ more than 4 #19

rizky opened this issue Apr 24, 2018 · 0 comments
Assignees
@fpetras
Labels
bug Something isn't working

Comments

@rizky
Copy link
Owner

rizky commented Apr 24, 2018 •
edited
Loading

The last file is invalid file.

To reproduce:
./corewar -dump 10 tests/asm/valid/Car.cor tests/asm/valid/Car.cor tests/asm/valid/Car.cor tests/asm/valid/Car.cor tests/asm/valid/Car.c
@rizky rizky added the bug Something isn't working label Apr 24, 2018
fpetras added a commit that referenced this issue Apr 24, 2018
@fpetras
Fix #19 by checking if all args are valid
afe7e5b
rizky added a commit that referenced this issue Apr 24, 2018
@rizky
Merge Fix #19
b0b34cc
fpetras added a commit that referenced this issue Apr 25, 2018
@fpetras
Fix bug
6d7fb8a 
Handle error if arg is a number but not preceded by valid option
Close #19
@rizky rizky closed this as completed Apr 25, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@fpetras fpetras

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@rizky @fpetras