Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cleanly separate logs and metrics for local errors vs downstream errors #1415

Open
sergekh2 opened this issue Nov 4, 2024 · 0 comments
Open

Cleanly separate logs and metrics for local errors vs downstream errors #1415

sergekh2 opened this issue Nov 4, 2024 · 0 comments
Labels
area/quality triage Triage during next triage session workitem Workitem that requires implementation

Comments

@sergekh2
Copy link
Contributor

sergekh2 commented Nov 4, 2024 •
edited
Loading

metrics and tags need to be tagged correctly.
Right now tags from RiverError are not propagated to the log message and error serialized as a string.
(Also, seems warnings on RPC handlers loose tags).
Specifically, tags need to clearly separate local errors and downstream errors.

On top of that DataDog understands specific error JSON and extracts more data from it, we are not using this JSON format.
@sergekh2 sergekh2 added area/quality triage Triage during next triage session workitem Workitem that requires implementation labels Nov 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area/quality triage Triage during next triage session workitem Workitem that requires implementation
Projects
River Planning Project
Status: No status
Milestone
No milestone
Development

No branches or pull requests
1 participant
@sergekh2