From 9c055ac5012c34960766c0e94b89313104000cb8 Mon Sep 17 00:00:00 2001
From: Li0k <yuli@singularity-data.com>
Date: Sun, 26 Jan 2025 17:00:35 +0800
Subject: [PATCH] fix(compactor): fix full key can concat

---
 src/storage/hummock_sdk/src/lib.rs | 58 +++++++++++++++++++++++++-----
 1 file changed, 50 insertions(+), 8 deletions(-)

diff --git a/src/storage/hummock_sdk/src/lib.rs b/src/storage/hummock_sdk/src/lib.rs
index f4da340b0a90f..fdf739fbe8375 100644
--- a/src/storage/hummock_sdk/src/lib.rs
+++ b/src/storage/hummock_sdk/src/lib.rs
@@ -318,17 +318,19 @@ pub fn full_key_can_concat(ssts: &[SstableInfo]) -> bool {
         let sst_2 = &ssts[i];
 
         if sst_1.key_range.right_exclusive {
-            if sst_1
-                .key_range
-                .compare_right_with(&sst_2.key_range.left)
-                .is_gt()
+            if KeyComparator::compare_encoded_full_key(
+                &sst_1.key_range.right,
+                &sst_2.key_range.left,
+            )
+            .is_gt()
             {
                 return false;
             }
-        } else if sst_1
-            .key_range
-            .compare_right_with(&sst_2.key_range.left)
-            .is_ge()
+        } else if KeyComparator::compare_encoded_full_key(
+            &sst_1.key_range.right,
+            &sst_2.key_range.left,
+        )
+        .is_ge()
         {
             return false;
         }
@@ -440,6 +442,9 @@ pub fn get_object_id_from_path(path: &str) -> HummockSstableObjectId {
 
 #[cfg(test)]
 mod tests {
+    use bytes::Bytes;
+    use sstable_info::SstableInfoInner;
+
     use super::*;
 
     #[test]
@@ -447,4 +452,41 @@ mod tests {
         let len = HummockSstableObjectId::MAX.to_string().len();
         assert_eq!(len, HUMMOCK_SSTABLE_OBJECT_ID_MAX_DECIMAL_LENGTH)
     }
+
+    #[test]
+    fn test_full_key_concat() {
+        let key1 = b"\0\0\0\x08\0\0\0\x0112-3\0\0\0\0\x04\0\x1c\x16l'\xe2\0\0";
+        let key2 = b"\0\0\0\x08\0\0\0\x0112-3\0\0\0\0\x04\0\x1c\x16l \x12\0\0";
+
+        let sst_1 = SstableInfoInner {
+            key_range: key_range::KeyRange {
+                left: Bytes::from(key1.to_vec()),
+                right: Bytes::from(key1.to_vec()),
+                right_exclusive: false,
+            },
+            ..Default::default()
+        };
+
+        let sst_2 = SstableInfoInner {
+            key_range: key_range::KeyRange {
+                left: Bytes::from(key2.to_vec()),
+                right: Bytes::from(key2.to_vec()),
+                right_exclusive: false,
+            },
+            ..Default::default()
+        };
+
+        let sst_3 = SstableInfoInner {
+            key_range: key_range::KeyRange {
+                left: Bytes::from(key1.to_vec()),
+                right: Bytes::from(key2.to_vec()),
+                right_exclusive: false,
+            },
+            ..Default::default()
+        };
+
+        assert!(full_key_can_concat(&[sst_1.clone().into(), sst_2.into()]));
+
+        assert!(!full_key_can_concat(&[sst_1.into(), sst_3.into()]));
+    }
 }