Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add io-uring constants #9

Merged
merged 2 commits into from
Dec 4, 2019
Merged

Conversation

twissel
Copy link

@twissel twissel commented Dec 3, 2019

Closes #8

@withoutboats
Copy link
Collaborator

Thanks for doing this!

The only issue is the types: we should set these consts to have the same types as the fields they'll be used to set, so for example IORING_FSYNC_DATASYNC should be a u32.

However, we should also use the libc types that we use in our definitions, that way there's no worry about a strange platform where u32 and libc::__u32 are not the same type. This also applies the op consts, which should be libc::__u8 instead of u8.

@twissel
Copy link
Author

twissel commented Dec 4, 2019

Agreed!

@withoutboats withoutboats merged commit 2557dff into ringbahn:master Dec 4, 2019
@withoutboats
Copy link
Collaborator

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

io_uring consts
2 participants