Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

client_auth_type and client_ca_file configs for mTLS #44

Open
bbeattie-phxlabs opened this issue Dec 7, 2021 · 1 comment
Open

client_auth_type and client_ca_file configs for mTLS #44

bbeattie-phxlabs opened this issue Dec 7, 2021 · 1 comment

Comments

@bbeattie-phxlabs
Copy link

https://github.com/ricoberger/script_exporter/blob/master/pkg/config/config.go#L19 limits TLS configuration to crt and key. Is there intent to adopt the https://github.com/prometheus/exporter-toolkit/blob/master/docs/web-configuration.md for things like client_auth_type: RequireAndVerifyClientCert?

@ricoberger
Copy link
Owner

Hi @bbeattie-phxlabs, I wasn't aware of the exporter-toolkit, but it looks very nice.

One problem I came across is that we have to introduce a second configuration file to get it working.

I created a PR (prometheus/exporter-toolkit#77) in the repository so that we can one configuration file for the script_exporter specific stuff and the exporter-toolkit configuration. Let's see what the maintainers are thinking about it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants