Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[feat] EdDSA algorithm #35

Open
beanow-at-crabnebula opened this issue May 30, 2023 · 5 comments
Open

[feat] EdDSA algorithm #35

beanow-at-crabnebula opened this issue May 30, 2023 · 5 comments

Comments

@beanow-at-crabnebula
Copy link

Has some great properties, like being deterministic, why you might choose it over the ECDSA family.

https://www.rfc-editor.org/rfc/rfc8037

@beanow-at-crabnebula
Copy link
Author

I should add, would you accept PRs on this feature? And are there any gotchas in contributing you can think of? :]

@rib
Copy link
Owner

rib commented Jun 3, 2023

Thanks. Yeah, I'd be happy to review a PR for adding EdDSA support. I'm not familiar with EdDSA atm but wouldn't expect any major gotchas, assuming it's supported in ring.

@beanow-at-crabnebula
Copy link
Author

Ring does support Ed25519 / X25519, but not Ed448 / X448.

The way I'm reading the RFC8037, it doesn't seem required to implement both. It seems to stress interoperability first.

@beanow-at-crabnebula
Copy link
Author

Sorry I haven't picked this up. I had conflated this library and https://github.com/Keats/jsonwebtoken
Currently evaluating their crate. Since they also use ring, there's support only for Ed25519 but not Ed448.

@rib
Copy link
Owner

rib commented Jun 19, 2023

:) no worries.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants