Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use tclib.expressions.compile_bool instead of tclib.expressions.eval_bool #2

Open
pholica opened this issue Feb 11, 2022 · 0 comments

Comments

@pholica
Copy link
Contributor

pholica commented Feb 11, 2022

Using the tclib.expressions.eval_bool repeatedly on the same jinja2 expression has effect on the performance. There's https://github.com/rhinstaller/tclib/pull/8 which should improve the situation in the tclib itself.

There are some places in the Permian where the tclib.expressions.eval_bool is used inside loops using the same jinja2 template string which leads to performance issues.

I can see one candidate in run_subset plugin which is worth fixing (especially when there are a lot of CRCs being filtered).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant