rpmostree: Use --merge for kargs
#6084
Conversation
cgwalters
had a problem deploying
to
gh-cockpituous
GitHub Actions
Failure
There was a problem hiding this comment.
Looks good to me.
I wonder if it couldn't be a fix for https://issues.redhat.com/browse/RHEL-66155 ?
|
/kickstart-test --testtype smoke |
|
/kickstart-test --testtype ostree |
I have no idea what's going on in that bug, kargs work elsewhere. I doubt this fixes it, but maybe. |
|
There are broken tests with this patch. Could you please fix them or I'm happy to fix your commit if you want me to do that. |
Without `--merge`, all kernel arguments will be replaced, which is not what is desired in general. Especially with bootc karg support which we definitely want to work with Anaconda. Signed-off-by: Colin Walters <[email protected]>
cgwalters
had a problem deploying
to
gh-cockpituous
GitHub Actions
Failure
|
I took a stab at that |
|
/kickstart-test --testtype smoke |
|
/kickstart-test --testtype ostree |
|
@cgwalters I'm thinking about creation of kickstart test for this functionality. How can we test this? |
Build a container adding https://containers.github.io/bootc/building/kernel-arguments.html#usrlibbootckargsd |
|
We discussed today how to approach this from the CI perspective. The issue is that we need a custom ISO to be able to test this with kickstart tests and these are not prepared for such an approach. To enable https://github.com/rhinstaller/kickstart-tests/ on a custom ISO we would need to change the ISO centric framework to be able to set a custom ISO for a specific test which will need some effort to do that. Anyway, we agreed that we don't want to block this simple patch on that but we would like to have this covered for RHEL backports if possible. Merging. |
Without
--merge, all kernel arguments will be replaced, which isnot what is desired in general. Especially with bootc karg support
which we definitely want to work with Anaconda.