pyanaconda: payload: split rsync command for /boot/efi to handle FAT filesystem limitations #6030
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KKoukiou
temporarily deployed
to
gh-cockpituous
GitHub Actions
Inactive
M4rtinK
approved these changes
Nov 29, 2024
KKoukiou
force-pushed
the
rhbz#2329379
branch
from
03a4ab8 to
556953a
Compare
KKoukiou
temporarily deployed
to
gh-cockpituous
GitHub Actions
Inactive
KKoukiou
force-pushed
the
rhbz#2329379
branch
from
556953a to
d415a17
Compare
KKoukiou
temporarily deployed
to
gh-cockpituous
GitHub Actions
Inactive
KKoukiou
force-pushed
the
rhbz#2329379
branch
from
d415a17 to
95fc1c2
Compare
KKoukiou
temporarily deployed
to
gh-cockpituous
GitHub Actions
Inactive
KKoukiou
force-pushed
the
rhbz#2329379
branch
from
95fc1c2 to
5918feb
Compare
KKoukiou
temporarily deployed
to
gh-cockpituous
GitHub Actions
Inactive
KKoukiou
force-pushed
the
rhbz#2329379
branch
from
5918feb to
6afbd12
Compare
KKoukiou
had a problem deploying
to
gh-cockpituous
GitHub Actions
Failure
|
/kickstart-tests --testtype smoke |
|
Verified it works. |
…filesystem limitations The previous rsync command attempted to preserve attributes (permissions, ownership, symlinks) that are not supported by FAT. This commit splits the rsync process for `/boot/efi` to avoid these incompatible options and ensure proper handling of FAT-specific filesystems. Resolves: rhbz#2329379
KKoukiou
force-pushed
the
rhbz#2329379
branch
from
6afbd12 to
65df88d
Compare
KKoukiou
temporarily deployed
to
gh-cockpituous
GitHub Actions
Inactive
jkonecny12
approved these changes
Nov 29, 2024
Comment on lines
+457
to
+458
| try: | ||
| execWithRedirect(cmd, args) |
There was a problem hiding this comment.
Could you please add
self.report_progress(_("Installing the /boot/efi content..."))
so this is not completely silent operation for users?
There was a problem hiding this comment.
I tested this interactively, and it tasks <1second to rsync this, it would be worse I believe to get the flashing string change.
There was a problem hiding this comment.
I see. In that case you can ignore this I guess.
|
/kickstart-tests --testtype smoke |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The previous rsync command attempted to preserve attributes (permissions, ownership, symlinks) that are not supported by FAT. This commit splits the rsync process for
/boot/efito avoid these incompatible options and ensure proper handling of FAT-specific filesystems.Resolves: rhbz#2329379