efi: Update __all__ dictionary #6024
Conversation
|
Hello @andreabolognani! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found: There are currently no PEP 8 issues detected in this Pull Request. Cheers! 🍻 Comment last updated at 2024-12-02 11:01:05 UTC |
andreabolognani
had a problem deploying
to
gh-cockpituous
GitHub Actions
Failure
andreabolognani
force-pushed
the
efi-all
branch
from
332457b to
8cdcfa5
Compare
andreabolognani
had a problem deploying
to
gh-cockpituous
GitHub Actions
Failure
|
/kickstart-test --testtype smoke |
andreabolognani
had a problem deploying
to
gh-cockpituous
GitHub Actions
Failure
KKoukiou
had a problem deploying
to
gh-cockpituous
GitHub Actions
Failure
|
Force pushed with a clean rebase to see the test failures clearly. |
KKoukiou
had a problem deploying
to
gh-cockpituous
GitHub Actions
Failure
KKoukiou
had a problem deploying
to
gh-cockpituous
GitHub Actions
Failure
There was a problem hiding this comment.
@andreabolognani this was failing on some new ruff sort checks. Hope it's fine that I fix it for you.
Add two missing entries (EFISystemdBoot, RISCV64EFIGRUB), then sort the dictionary so that classes are listed in the same order as they appear in the file, which will hopefully make it easier to spot mistakes in the future, and wrap lines so that the linter doesn't complain about them being too long. Signed-off-by: Andrea Bolognani <[email protected]>
KKoukiou
had a problem deploying
to
gh-cockpituous
GitHub Actions
Failure
|
/kickstart-tests --waive ran already |
|
@KKoukiou by all means, thank you! I tried running the tests locally but some of them were failing even when on the |
|
Web UI tests dont have currently ability to run for external contributors, this PR is unrelated anyhow. |
|
Thanks a lot @KKoukiou! :) |
Add two missing entries (
EFISystemdBoot,RISCV64EFIGRUB) and sort the dictionary so that classes are listed in the same order as they appear in the file, which will hopefully make it easier to spot mistakes in the future.I'm not actually sure whether or not this makes any difference, but since all other classes are listed I assume the dictionary is there for a reason...