Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move reduceDataFrame from QFeatures to MsCoreUtils #93

Open
lgatto opened this issue Dec 12, 2021 · 1 comment
Open

Move reduceDataFrame from QFeatures to MsCoreUtils #93

lgatto opened this issue Dec 12, 2021 · 1 comment

Comments

@lgatto
Copy link
Member

lgatto commented Dec 12, 2021 •
edited
Loading

I am using QFeatures::reduceDataFrame() in PSMatch, which now depends on the former just for that (low-level) function. What about moving this file from QFeatures to MsCoreUtils?

@sgibb @jorainer
@jorainer
Copy link
Member

Looks good to me. Question: that does only work for DataFrame, right? Any plans to have that implemented for data.frame too? And also, most NumericList etc have the parameter compressed = TRUE, how does your function work with that? I had the impression that compressed lists are slower.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@lgatto @jorainer