Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

first and last points of stat_stat_etho should join on polar coordinates #36

Open
qgeissmann opened this issue May 9, 2020 · 0 comments

Comments

@qgeissmann
Copy link
Contributor

One of the issues of #34. Reproducible example:

library(ggetho)
metadata <- data.frame(id = sprintf("toy_experiment | %02d", 1:20),
                       condition = c("A", "B"))
dt <- toy_activity_data(metadata, 3)
pl <-  ggetho(dt, aes(y = asleep), time_wrap = behavr::hours(24), time_offset = behavr::hours(6)) + 
  stat_pop_etho() +coord_polar()   
pl

image

This is absolutely expected since we are drawing a line and a ribbon (and that would look terible on a non_polar coordinate system if the last and first point were joined) and not a polygon. Maybe we add an argument in stat_pop_etho such as close_path=TRUE to force drawing last line?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant