Github Auth Issue: Failed to fetch user profile error message

[uxinkc]

Describe the bug
When selecting Github as the login method, I now get "Failed to fetch user profile" error message. We have had Wiki.js installed and working for months now without any issues like this. The only change that I am aware of is adding HTTPS to our wiki.js installation on AWS.

To Reproduce

Process One: Already signed in to Github

Steps to reproduce the behavior:

1. Go to Login screen:

2. Click on Github button to login and the page turns to this.
   

Process Two: Not Signed in to Github

Steps to reproduce the behavior:

1. Go to Login screen:

2. Click on Github button to login.

3. Page loads the Sign in to Github callback screen:
   

4. Redirect shows this error:
   

Expected behavior
Being able to sign in using Github as previously

Host Info (please complete the following information):

• OS: Ubuntu 18.04, Docker
• Wiki.js version: 2.4.107
• Database engine: PostgreSQL 11.6

Additional context
As stated above, we previously have been able to login using github as our authenticator, but now we cannot.

[winkelement]

The only change that I am aware of is adding HTTPS to our wiki.js installation on AWS.

Have you adjusted your Authorization callback URL like https://YOUR-WIKI-DOMAIN/login/github/callback?

[uxinkc]

@winkelement Yes, I have tried to use both http://... and https://... with the callback you listed above, but neither seem to work.

[uxinkc]

I found a solution. The Site URL in the General section wasn't set to https:

And after I updated that to https, I ALSO had got to the Authentication section and toggle the github strategy from Active to Inactive... Click Apply... and then toggle it back to Active again and click Apply. This somehow initiated the the reset of the system to use the https URL as the redirect. Without doing this weird toggle action, they system would not reset to https

Previously, the Auth Strategy Configuration settings looks like this...

After updating the Site URL, the Auth Strategy Configuration settings look like the below, but did not allow for the use of Github authentication.

It wasn't until I performed the Toggle off/on of the github Auth and clicked Apply that the changes finally took affect.

This is for sure a bug, because a User would not expect to have to update the Site URL in a completely different section AND toggle the Authentication for github a few times after they have implemented SSL. Updating 3 different unrelated sections, seems like a lot to try and explain.

In the SSL section, if I click TURN ON Redirect HTTP requests to HTTPS, the system should do a system wide check for http and swap out with https.