Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rounding errors sum up after 5 resizes #5

Open
diederikfeilzer opened this issue Jun 17, 2015 · 1 comment · May be fixed by #7
Open

Rounding errors sum up after 5 resizes #5

diederikfeilzer opened this issue Jun 17, 2015 · 1 comment · May be fixed by #7

Comments

@diederikfeilzer
Copy link

Hi, Great plugin, I noticed that when the user does a couple of resizes, the rounding errors seem to sum up and aspect-ratios of the images are lost. Since modern browsers seem to handle decimal places in style tags very well I suggest you either use the decimal places like 123.45995 px to increase the number of allowed resizes or completely redraw each time, but I get that last one is not preferable. Maybe store the original aspect ratios in a data-aspectratio attribute in the image its self.
@vburlak
Copy link

vburlak commented Nov 2, 2015

hi, @diederik789
Have you any thoughts at this issue?

@tkosse tkosse linked a pull request Feb 25, 2017 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Huge update on the gallery tkosse/BalancedGallery
2 participants
@vburlak @diederikfeilzer