Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhancement Request: GZIP support (tar mode) #1

Closed
Pwntus opened this issue May 10, 2023 · 2 comments · Fixed by #183
Closed

Enhancement Request: GZIP support (tar mode) #1

Pwntus opened this issue May 10, 2023 · 2 comments · Fixed by #183
Assignees
Labels
enhancement New feature or request

Comments

@Pwntus
Copy link
Member

Pwntus commented May 10, 2023

Writing down how I implemented ZIP at first. As discussed, weights are not good for ZIP compression due to their "noisy" structure - decompressing with ZIP adds ~50-60 seconds.

  1. Import compress/gzip.
  2. When extracting, first create a uncompressed stream before feeding to the tar reader:
func extractTarFile(buffer *bytes.Buffer, destDir string) error {
  uncompressedStream, err := gzip.NewReader(buffer)
  if err != nil {
    return err
  }

  tarReader := tar.NewReader(uncompressedStream)
  // ...
}
@tempusfrangit
Copy link
Contributor

tempusfrangit commented Nov 30, 2023

This should be much easier to implement now as a consumer, do we want it?

@tempusfrangit tempusfrangit added the enhancement New feature or request label Nov 30, 2023
@tempusfrangit tempusfrangit changed the title Note: ZIP support Enhancement Request: ZIP support Nov 30, 2023
@tempusfrangit tempusfrangit changed the title Enhancement Request: ZIP support Enhancement Request: GZIP support (tar mode) Feb 15, 2024
@tempusfrangit
Copy link
Contributor

Ignore the reference from #158, that was incorrect.

@tempusfrangit tempusfrangit self-assigned this Mar 14, 2024
emaballarin added a commit to emaballarin/rpget that referenced this issue Jan 18, 2025
…/github.com/golangci/golangci-lint-1.63.4

Bump github.com/golangci/golangci-lint from 1.62.2 to 1.63.4
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants