Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Compatibility issues with iOS versions due to hasOwn in react-markdown and regex in mdast-util-gfm-autolink-literal #888

Closed
4 tasks done
guoshencheng opened this issue Feb 11, 2025 · 4 comments
Labels
👯 no/duplicate Déjà vu 👎 phase/no Post cannot or will not be acted on

Comments

@guoshencheng
Copy link

Initial checklist

Affected package

mdast-util-gfm-autolink-literal

Steps to reproduce

Use react-markdown with the mdast-util-gfm-autolink-literal dependency.
Test the rendering of Markdown content on various versions of iOS (maybe iOS 14).
Observe the compatibility issues resulting from the use of hasOwn and the regular expression limitations.

Actual behavior

crash and get some js error

hasOwn is not a function

Regexp error

Expected behavior

render success

Runtime

No response

Package manager

No response

Operating system

iOS 14.5

Build and bundle tools

No response

@github-actions github-actions bot added 👋 phase/new Post is being triaged automatically 🤞 phase/open Post is being triaged manually and removed 👋 phase/new Post is being triaged automatically labels Feb 11, 2025
@ChristianMurphy
Copy link
Member

Duplicate of syntax-tree/mdast-util-gfm-autolink-literal#10 and #804

This comment has been minimized.

Copy link

Hi! Thanks for taking the time to contribute!

Because we treat issues as our backlog, we close duplicates to focus our work and not have to touch the same chunk of code for the same reason multiple times. This is also why we may mark something as duplicate that isn’t an exact duplicate but is closely related.

Thanks,
— bb

This comment has been minimized.

@github-actions github-actions bot added 👎 phase/no Post cannot or will not be acted on and removed 🤞 phase/open Post is being triaged manually labels Feb 11, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
👯 no/duplicate Déjà vu 👎 phase/no Post cannot or will not be acted on
Development

No branches or pull requests

2 participants