Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

How do I add a renderer for abbreviations in react-markdown? #369

Closed
ruchiagarwal75 opened this issue Nov 25, 2019 · 2 comments
Closed

How do I add a renderer for abbreviations in react-markdown? #369

ruchiagarwal75 opened this issue Nov 25, 2019 · 2 comments
Labels
👀 no/external This makes more sense somewhere else

Comments

@ruchiagarwal75
Copy link

ruchiagarwal75 commented Nov 25, 2019

Trying to render abbreviations for my markdown that looks like this :

Page Intro Description" field
*[Intro]: Here's a big definition. 

But there is no way to add an abbreviations renderer. Wondering how can I achieve this?

Note: I also tried using the plugin remark-abbr, but it throws an error saying
Renderer for type abbr not defined or is not renderable

@ChristianMurphy
Copy link
Member

This would be resolved by #428, which uses remark-rehype which remark-abbr is designed to work with.

@ChristianMurphy ChristianMurphy added 🌊 blocked/upstream This cannot progress before something external happens first 👀 no/external This makes more sense somewhere else labels Oct 8, 2020
@wooorm
Copy link
Member

wooorm commented Oct 19, 2020

This can be solved outside of this project, hence I’ll close this here.

It could be done by depending on https://github.com/zestedesavoir/zmarkdown/tree/master/packages/remark-abbr#options, although that still needs to be updated for the new parser in remark, and then specifying a custom renderer.

@wooorm wooorm removed the 🌊 blocked/upstream This cannot progress before something external happens first label Oct 19, 2020
@wooorm wooorm closed this as completed Oct 19, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
👀 no/external This makes more sense somewhere else
Development

No branches or pull requests

3 participants