Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

relay/must-colocate-fragment-spreads not working as expected on union types #135

Open
richardtagger opened this issue Jan 22, 2023 · 0 comments

Comments

@richardtagger
Copy link

With the following code I'm getting issues on fragment spreads. I've tried shifting things about a bit but can't work out what the issue is. The code executes fine at runtime.

export const MessageSenderAvatar: FC<MessageSenderAvatarProps> = ({
  messageSenderAvatarRef = null,
}) => {
  const fragmentRef = useFragment(
    graphql`
      fragment MessageSenderAvatarFragment on Message {
        sender {
          __typename
          ... on User {
            ...UserAvatarFragment <--- ISSUE
          }
          ... on Bot {
            ...BotAvatarFragment <--- ISSUE
          }
        }
      }
    `,
    messageSenderAvatarRef
  );

  if (fragmentRef == null) {
    return null;
  }

  if (fragmentRef.sender.__typename === 'User') {
    return <UserAvatar userAvatarRef={fragmentRef.sender} />;
  }

  if (fragmentRef.sender.__typename === 'Bot') {
    return <BotAvatar botAvatarRef={fragmentRef.sender} />;
  }

  return <AnonymousUserAvatar />;
};

and UserAvatar such as

export const UserAvatar: FC<UserAvatarProps> = ({ userAvatarRef, size = AvatarSize.Size40 }) => {
  const { avatarUrlTemplate, displayName } = useFragment(
    graphql`
      fragment UserAvatarFragment on User {
        avatarUrlTemplate
        displayName
      }
    `,
    userAvatarRef
  );

  return (
    <AvatarView
      name={displayName}
      imageUrl={getScaledUrlTemplate(avatarUrlTemplate, size)}
      size={size}
    />
  );
};
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant