Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Investigate downloading binaries (instead of including) & reusing existing ones on the path #4555

Open
adietish opened this issue Oct 14, 2024 · 3 comments

Comments

@adietish
Copy link
Contributor

we currently include binaries in the extension. We should look into downloading them at runtime and maybe even use binaries that exist on the path.

@rgrunber
Copy link
Member

Might be worth looking back on #1227 , #10 . Is the goal here to reduce the extension size ? Or do you want a given release to be usable without having to upgrade (to one that has the proper embedded version). If so, is there evidence that users aren't mainly just upgrading to latest release ?

@vrubezhny
Copy link
Contributor

@rgrunber Yet another issue to target here is #4535 - Che Workstation is running on RHEL 8 and has GLIBC v 2.88 installed that prevents the most recent versions of some bundled binaries (oc, odo, alizer) from being executed as they require GLIBC v.2.32+/v2.34+ to be installed.
Allowing the use of preinstalled binaries (search in user PATH) or manual installation of the required CLI binaries could help.

@rgrunber
Copy link
Member

On LemMinX, we ship a separate (static) binary for distros that don't have glibc. Is that an option here ? Have a static version of the binaries that would work ? Otherwise, yeah downloading some older version is one way around it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants