Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: bump kubernetes-client to 7.0.0 (#921) #922

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

adietish
Copy link
Contributor

@adietish adietish commented Oct 8, 2024

depends on merging redhat-developer/intellij-common#247 and publishing intellij-common afterwards
fixes #921

@adietish adietish self-assigned this Oct 8, 2024
Copy link

openshift-ci bot commented Oct 8, 2024

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

Copy link

sonarqubecloud bot commented Oct 8, 2024

@adietish
Copy link
Contributor Author

adietish commented Oct 8, 2024

Some maven artifacts seem not available in the maven repo yet. The build works fine locally (with locally built kubernetes-client artifacts) though.

➜  intellij-openshift-connector git:(issue-921) ✗ ./gradlew clean buildPlugin

> Task :patchPluginXml
[gradle-intellij-plugin :patchPluginXml] Patching plugin.xml: value of 'version[1.0]' tag will be set to '1.10.2-SNAPSHOT'

> Task :verifyPluginConfiguration
[gradle-intellij-plugin :verifyPluginConfiguration] The following plugin configuration issues were found:
- The 'since-build' property is lower than the target IntelliJ Platform major version: 223 < 241.
See: https://jb.gg/intellij-platform-versions

> Task :compileJava
Note: Some input files use or override a deprecated API.
Note: Recompile with -Xlint:deprecation for details.
Note: Some input files use unchecked or unsafe operations.
Note: Recompile with -Xlint:unchecked for details.

> Task :compileTestJava
Note: /Users/adietish/Documents/jboss-workspaces/intellij-openshift-connector/src/test/java/org/jboss/tools/intellij/openshift/actions/ActionTest.java uses unchecked or unsafe operations.
Note: Recompile with -Xlint:unchecked for details.

> Task :compileIntegrationTestJava
Note: Some input files use unchecked or unsafe operations.
Note: Recompile with -Xlint:unchecked for details.

Deprecated Gradle features were used in this build, making it incompatible with Gradle 9.0.

You can use '--warning-mode all' to show the individual deprecation warnings and determine if they come from your own scripts or plugins.

For more on this, please refer to https://docs.gradle.org/8.5/userguide/command_line_interface.html#sec:command_line_warnings in the Gradle documentation.

BUILD SUCCESSFUL in 10s
16 actionable tasks: 16 executed

@adietish
Copy link
Contributor Author

adietish commented Dec 3, 2024

kubernetes-client 7.0 was released: https://repo1.maven.org/maven2/io/fabric8/kubernetes-client/7.0.0/

@adietish adietish changed the title fix: bump kubernetes-client to 7.0-SNAPSHOT (#921) fix: bump kubernetes-client to 7.0.0 (#921) Dec 3, 2024
Copy link

sonarqubecloud bot commented Dec 3, 2024

@adietish
Copy link
Contributor Author

adietish commented Dec 6, 2024

Quite some changes required to be able to do the bump:

  • config watcher has to hand over the new (merged) config, not the config file that changed
        public interface Listener {
          void onUpdate(Config updatedConfig);
      }
    This then requires ApplicationsRootNode to hold a client instance that it is replacing if a meaningful change of a config file occurred. It then has to recreate odo and oc binaries with the new client.
  • checking if a cluster is an OpenShift cluster now relies on client.hasApiGroup("openshift.io", false). There's no OpenShiftClient#isSupported any more.
  • all tests have to be realigned with the lifecycle changes.
  • etc.

@adietish adietish force-pushed the issue-921 branch 2 times, most recently from da4dd97 to 778e652 Compare December 13, 2024 10:46
Copy link

openshift-ci bot commented Dec 13, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please ask for approval from adietish. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@@ -189,4 +190,9 @@ public void run() {
);
}
}

@Override
public @NotNull ActionUpdateThread getActionUpdateThread() {
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This could/should have arguably been fixed in a separate issue. When the cluster isn't reachable, the EDT is stuck waiting and the platform throws an exception indicating this fix.

@adietish adietish force-pushed the issue-921 branch 3 times, most recently from dae73b9 to 7916db8 Compare January 8, 2025 14:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bump kubernetes-client 7.0.0
2 participants