-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: bump kubernetes-client to 7.0.0 (#921) #922
base: main
Are you sure you want to change the base?
Conversation
Skipping CI for Draft Pull Request. |
Quality Gate passedIssues Measures |
Some maven artifacts seem not available in the maven repo yet. The build works fine locally (with locally built kubernetes-client artifacts) though. ➜ intellij-openshift-connector git:(issue-921) ✗ ./gradlew clean buildPlugin
> Task :patchPluginXml
[gradle-intellij-plugin :patchPluginXml] Patching plugin.xml: value of 'version[1.0]' tag will be set to '1.10.2-SNAPSHOT'
> Task :verifyPluginConfiguration
[gradle-intellij-plugin :verifyPluginConfiguration] The following plugin configuration issues were found:
- The 'since-build' property is lower than the target IntelliJ Platform major version: 223 < 241.
See: https://jb.gg/intellij-platform-versions
> Task :compileJava
Note: Some input files use or override a deprecated API.
Note: Recompile with -Xlint:deprecation for details.
Note: Some input files use unchecked or unsafe operations.
Note: Recompile with -Xlint:unchecked for details.
> Task :compileTestJava
Note: /Users/adietish/Documents/jboss-workspaces/intellij-openshift-connector/src/test/java/org/jboss/tools/intellij/openshift/actions/ActionTest.java uses unchecked or unsafe operations.
Note: Recompile with -Xlint:unchecked for details.
> Task :compileIntegrationTestJava
Note: Some input files use unchecked or unsafe operations.
Note: Recompile with -Xlint:unchecked for details.
Deprecated Gradle features were used in this build, making it incompatible with Gradle 9.0.
You can use '--warning-mode all' to show the individual deprecation warnings and determine if they come from your own scripts or plugins.
For more on this, please refer to https://docs.gradle.org/8.5/userguide/command_line_interface.html#sec:command_line_warnings in the Gradle documentation.
BUILD SUCCESSFUL in 10s
16 actionable tasks: 16 executed |
kubernetes-client 7.0 was released: https://repo1.maven.org/maven2/io/fabric8/kubernetes-client/7.0.0/ |
Quality Gate passedIssues Measures |
Quite some changes required to be able to do the bump:
|
da4dd97
to
778e652
Compare
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@@ -189,4 +190,9 @@ public void run() { | |||
); | |||
} | |||
} | |||
|
|||
@Override | |||
public @NotNull ActionUpdateThread getActionUpdateThread() { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This could/should have arguably been fixed in a separate issue. When the cluster isn't reachable, the EDT is stuck waiting and the platform throws an exception indicating this fix.
dae73b9
to
7916db8
Compare
Signed-off-by: Andre Dietisheim <[email protected]>
depends on merging redhat-developer/intellij-common#247 and publishing intellij-common afterwards
fixes #921