Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix usage of deprecated APIs #732

Open
mohitsuman opened this issue Mar 4, 2024 · 5 comments · May be fixed by #740
Open

Fix usage of deprecated APIs #732

mohitsuman opened this issue Mar 4, 2024 · 5 comments · May be fixed by #740
Assignees
@adietish
Labels
enhancement New feature or request IC-2023.1 IC-2023.2 IC-2023.3

Comments

@mohitsuman
Copy link
Collaborator

[kind/Enhancement]

OpenShift Toolkit by Red Hat 1.8.0 uses deprecated API, which may be removed in future releases leading to binary and source code incompatibilities

Screenshot 2024-03-04 at 6 36 54 PM
@adietish
Copy link
Contributor

adietish commented Mar 12, 2024 •
edited
Loading

  • ModuleListener.moduleAdded(Project, Module):
    replaced by ModuleListener.modulesAdded(Project, List<? extends Module>) but not available before IC-2023.1
  • IconManager.getIcon(String, Class):
    replaced by IconManager.getIcon(String, ClassLoader but not available before IC-2023.2
    -> wont correct before we use 2023.2 as minimum version.
  • ProjectTopics.MODULES:
    replaced by ModuleListener.TOPIC but not available before IC-2023.3
    -> wont correct before we use 2023.3 as minimum version

adietish added a commit to adietish/intellij-openshift-connector that referenced this issue Mar 12, 2024
@adietish
corrected deprecated usage of ModuleLister.moduleAdded (redhat-develo…
3986f02 
…per#732)

Signed-off-by: Andre Dietisheim <[email protected]>
@adietish adietish linked a pull request Mar 12, 2024 that will close this issue
Draft
@adietish
Copy link
Contributor

adietish commented Mar 12, 2024 •
edited
Loading

#740 only fixes 1 of the 3 issues but requires IC-2023.1.

@adietish adietish self-assigned this Mar 12, 2024
@adietish adietish moved this to 👀 In review in IDE Cloudaptors Mar 12, 2024
adietish added a commit to adietish/intellij-openshift-connector that referenced this issue Mar 12, 2024
@adietish
fix: corrected deprecated usage of ModuleLister.moduleAdded (redhat-d…
8120951 
…eveloper#732)

Signed-off-by: Andre Dietisheim <[email protected]>
adietish added a commit to adietish/intellij-openshift-connector that referenced this issue Mar 12, 2024
@adietish
fix: corrected deprecated usage of ModuleLister.moduleAdded (redhat-d…
f6109f5 
…eveloper#732)

Signed-off-by: Andre Dietisheim <[email protected]>
@adietish adietish moved this from 👀 In review to 📋 Backlog in IDE Cloudaptors Mar 13, 2024
@adietish adietish mentioned this issue Mar 15, 2024
Merged
adietish added a commit to adietish/intellij-openshift-connector that referenced this issue Apr 17, 2024
@adietish
fix: corrected deprecated usage of ModuleLister.moduleAdded (redhat-d…
bf05401 
…eveloper#732)

Signed-off-by: Andre Dietisheim <[email protected]>
adietish added a commit to adietish/intellij-openshift-connector that referenced this issue Jun 28, 2024
@adietish
fix: corrected deprecated usage of ModuleLister.moduleAdded (redhat-d…
95668bb 
…eveloper#732)

Signed-off-by: Andre Dietisheim <[email protected]>
@sbouchet sbouchet mentioned this issue Jul 18, 2024
Merged
@sbouchet
Copy link
Collaborator

We're now down at two, one that will be fixed with #740 when bumping to newer version, and last is about fabric8 client lib that might be resolved when also bumping to newer release of it.

@adietish adietish removed the status in IDE Cloudaptors Aug 7, 2024
@adietish adietish moved this to 📋 Backlog in IDE Cloudaptors Aug 7, 2024
@mohitsuman
Copy link
Collaborator Author

@sbouchet any update on this issue ?

@sbouchet
Copy link
Collaborator

sbouchet commented Oct 1, 2024

@mohitsuman : current situation for minimal version support is below, and can't be fixed without bumping both openshift client and minimal IDEA version.
image

adietish added a commit to adietish/intellij-openshift-connector that referenced this issue Oct 2, 2024
@adietish
fix: corrected deprecated usage of ModuleLister.moduleAdded (redhat-d…
47e3265 
…eveloper#732)

Signed-off-by: Andre Dietisheim <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@adietish adietish

Labels
enhancement New feature or request IC-2023.1 IC-2023.2 IC-2023.3
Projects
None yet
Milestone
No milestone
3 participants
@adietish @sbouchet @mohitsuman