Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Typo at task teams from role filetree_read misplacement of variable controller_roles instead controller_teams #16

Closed
fernandorocagonzalez opened this issue Jan 13, 2025 · 3 comments · Fixed by #19
Labels
bug Something isn't working

Comments

@fernandorocagonzalez
Copy link

fernandorocagonzalez commented Jan 13, 2025

Verified there is not an already issue related to the same topic

Not for help, the issue regards a typo (probably copy paste from the developer)

Affected release: latest 2.11.0 and others

Summary

Issue Type

  • Bug Report

There is a typo at yaml file
roles/filetree_read/tasks/teams.yml

it contains a task with a set_fact defining controller_roles but it should define controller_teams:

  • name: "Set Roles Data Structure"
    ansible.builtin.set_fact:
    controller_roles: >- <----- wrong variable name it should be controller_teams
    {{
    __contents_filetree_controller_teams.results |
    rejectattr('ansible_facts.controller_teams', 'undefined') |
    map(attribute='ansible_facts.controller_teams') |
    ansible.builtin.flatten
    }}
    no_log: "{{ controller_configuration_filetree_read_secure_logging }}"
    when: __contents_filetree_controller_teams.results
    ...

But it should be: controller_teams instead controller_roles

  • name: "Set Roles Data Structure"
    ansible.builtin.set_fact:
    controller_teams: >-
    {{
    __contents_filetree_controller_teams.results |
    rejectattr('ansible_facts.controller_teams', 'undefined') |
    map(attribute='ansible_facts.controller_teams') |
    ansible.builtin.flatten
    }}
    no_log: "{{ controller_configuration_filetree_read_secure_logging }}"
    when: __contents_filetree_controller_teams.results
    ...

STEPS TO REPRODUCE

Just open the tarbal file an take a look

That just makes impossible creating teams

@fernandorocagonzalez fernandorocagonzalez added the bug Something isn't working label Jan 13, 2025
@djdanielsson djdanielsson transferred this issue from redhat-cop/infra.aap_configuration Jan 17, 2025
@djdanielsson
Copy link
Contributor

@ivarmu

@ivarmu ivarmu added duplicate This issue or pull request already exists and removed duplicate This issue or pull request already exists labels Jan 17, 2025
@ivarmu
Copy link
Contributor

ivarmu commented Jan 17, 2025

This has already been solved at redhat-cop/aap_configuration_extended#58

@djdanielsson
Copy link
Contributor

yes but they are using controller_configuration not the new aap_configuration so this needs to be back ported. @ivarmu

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants