Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

An attempt to update controller-runtime to v0.19 #11

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

An attempt to update controller-runtime to v0.19 #11

wants to merge 4 commits into from

Conversation

shadialtarsha
Copy link

@shadialtarsha shadialtarsha commented Jan 12, 2025 •
edited
Loading

Closes #12

💸 TL;DR

  • Updating controller-runtime to version v.0.19.4
  • Removing WatchesRawResource - breaking change.

📜 Details

Due to the recent breaking PRs on controller-runtime kubernetes-sigs/controller-runtime#2799 and kubernetes-sigs/controller-runtime#2783, I had to make some decisions and I would appreciate your inputs on it:

  1. Replace WatchesRawSource with two new builder functions: WatchesChannel and WatchesKind because you cannot create a raw source.Source anymore.
  2. Thus, we cannot do WatchesRawResource anymore because we cannot wrap the handler with our own observer.
  3. Switch all the RateLimiter functions to be typed.

🧪 Testing Steps / Validation

I replaced the SDK on my Ingress Controller and things look like they are working. I will do more tests as well to make sure we are good.

✅ Checks

  • CI tests (if present) are passing
  • Adheres to code style for repo
  • Contributor License Agreement (CLA) completed if not a Reddit employee

@shadialtarsha shadialtarsha changed the title [Not Ready] An attempt to update controller-runtime to v0.19 An attempt to update controller-runtime to v0.19 Jan 19, 2025
@shadialtarsha shadialtarsha marked this pull request as ready for review January 19, 2025 14:01
@shadialtarsha shadialtarsha requested a review from a team as a code owner January 19, 2025 14:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@harveyxia harveyxia Awaiting requested review from harveyxia harveyxia is a code owner automatically assigned from reddit/achilles

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Update controller-runtime to v0.19.4
2 participants
@shadialtarsha @harveyxia