-
-
Notifications
You must be signed in to change notification settings - Fork 138
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for custom subtitle styling when using torrents. #561
Comments
💡 Thank you for your feature request! 📈 What to Expect Next
👥 Stay Connected
We appreciate your suggestion and look forward to potentially implementing it! |
After lurking around in their Discord, another person also has mentioned this issue and one of the devs said that this is a known issue and will likely never be fixed. A shame but oh well, I guess it's safe to assume to close this issue as not planned myself cause the devs seems rather busy to actually interact with these issue which I understand. |
Please don't close it, who knows someone might work on this later🤷. |
Good point I guess, just don't really like the inactivity even though I know why. I'll keep it opened, really sorry for that. |
Feature Summary
Just like the title said, with the new release adding support for HEVC codecs (which a lot of torrent uses), not being able to see the cool and beautiful subtitles that are provided in those torrents is a shame so being able to add support to this would make the app really perfect.
Detailed Description
Current Behavior
Without the support for this, most subtitles (especially OP/ED subs) becomes quite boring and worst case scenario, even break.
Proposed Solution
While I don't know how this could really work since I'm not really a programmer or anything like that, you could probably do it how just like most media players do it (i.e VLC and mpv). There are even others open-source anime-focused torrent streaming app that I'm pretty sure also uses Exoplayer like Dantotsu does so there's that!
Considerations
I'm not really sure for this part, sorry.
Additional Context
Here's some video examples (sorry for the shitty editing lol), this showcases how the default subtitles that torrents uses (marked by the red logo of a particular app uses, won't really mention cause I'm afraid I'll break some rule) and how those subtitles are displayed inside Dantotsu. First video just showcases the subtitles of the Death Note 2nd opening while the other video showcases just how bothering it can be if this feature is not supported anytime soon.
https://files.catbox.moe/xt06lq.mp4
https://files.catbox.moe/qk8q21.mp4
(P.S. Seems like there's a bug also, whenever you wanna play an episode (especially the first episode it seems) but you've already finish that episode all the way through it will show you a toast saying Player Error 1000, I don't know if I can copy toasts messages so all I got is a screenshot, sorry. Anyway here it is. Thanks in advance!
Submission Checklist
The text was updated successfully, but these errors were encountered: