Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleanup for menus and web components #535

Open
5 tasks
agjohnson opened this issue Dec 5, 2024 · 0 comments
Open
5 tasks

Cleanup for menus and web components #535

agjohnson opened this issue Dec 5, 2024 · 0 comments
Labels
Accepted Accepted issue on our roadmap Improvement Minor improvement to code

Comments

@agjohnson
Copy link
Contributor

This is a follow up to

To cut down on complexity I only did the bare minimum to test out the patterns of nested web components.

Still left is:

  • Refactor readthedocs-menu-build-rebuild to use data provided CSRF token
  • Refactor button and menu WC to use context API data
  • Deprecate APIEventWrapper
  • Listen for multiple events to kick off API request
  • Restructure of includes if needed
@agjohnson agjohnson added Accepted Accepted issue on our roadmap Improvement Minor improvement to code labels Dec 5, 2024
@agjohnson agjohnson added this to the Deprecation and cleanup milestone Dec 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Accepted Accepted issue on our roadmap Improvement Minor improvement to code
Projects
None yet
Development

No branches or pull requests

1 participant