Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use CSS custom properties where possible #44

Open
chocolatkey opened this issue Jul 23, 2024 · 0 comments
Open

Use CSS custom properties where possible #44

chocolatkey opened this issue Jul 23, 2024 · 0 comments
Labels
enhancement New feature or request

Comments

@chocolatkey
Copy link
Member

There's a lot of places in the code where variable styling of elements (especially in the EPUB navigators) is done using assignment to style attributes with string interpolation, e.g. translate3d(${this.offset}px, 0, 0). It is better for long-term understanding and maintenance of the code if this is done with CSS variables instead where possible.

@chocolatkey chocolatkey added the enhancement New feature or request label Jul 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant